-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an opportunity to check if docker/docker compose is installed on … #5618
Conversation
…BOINC-client and send the information to BOINC-server for correct schedulling
@Tanya1515, thank you for your PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5618 +/- ##
============================================
- Coverage 10.54% 10.52% -0.02%
Complexity 1068 1068
============================================
Files 279 279
Lines 35869 35915 +46
Branches 8409 8427 +18
============================================
- Hits 3781 3779 -2
- Misses 31694 31742 +48
Partials 394 394
|
@AenBleidd I have improved my code (all misprints and whitespaces are fixed). However, CI flows are failed on test covering. All files, that i have modified, don't have test covering at all. What should i do with the error? Thank you in advance. |
@Tanya1515, code coverage is not important and can be ignored. |
@AenBleidd, have you taken look at the code/my issue[https://github.com//issues/5617]? Thank you in advance. |
Hello @Tanya1515, sorry for the delay. We were busy releasing a new version of BOINC. I plan to review and test your PR during next couple of weeks. |
Closing this in favor of #5757 that contains a better approach of docker detection. |
Pull request for issue 5617