Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fix running on Ubuntu 24.04 #5992

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Conversation

AenBleidd
Copy link
Member

No description provided.

Signed-off-by: Vitalii Koshura <[email protected]>
@AenBleidd AenBleidd added this to the Client/Manager 8.0.5 milestone Jan 5, 2025
@Copilot Copilot bot review requested due to automatic review settings January 5, 2025 16:47

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • mingw/ci_make_apps.sh: Language not supported
Comments suppressed due to low confidence (1)

.github/workflows/android.yml:221

  • There is an extra space before the colon in the if condition. It should be 'if: ${{ success() }}'.
if : ${{ success() }}
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.70%. Comparing base (b2c8498) to head (75a5434).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5992      +/-   ##
============================================
- Coverage     10.70%   10.70%   -0.01%     
  Complexity     1068     1068              
============================================
  Files           280      280              
  Lines         36710    36713       +3     
  Branches       8515     8513       -2     
============================================
  Hits           3930     3930              
- Misses        32391    32394       +3     
  Partials        389      389              

see 1 file with indirect coverage changes

@AenBleidd AenBleidd merged commit 3562c78 into master Jan 5, 2025
154 checks passed
@AenBleidd AenBleidd deleted the vko_fix_ci_running_ubuntu_24.04 branch January 5, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

1 participant