Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenSSL built-in engines and add automation tests #6022

Merged
merged 5 commits into from
Jan 25, 2025

Conversation

AenBleidd
Copy link
Member

No description provided.

musicinmybrain and others added 5 commits January 5, 2025 10:07
The ENGINE API is deprecated in OpenSSL 3.0; the intended replacement is
the Provider API.

See also #5356, for which this addresses one (but not all) of the
reported deprecation warnings.
Automation tests have been added for the crypt_prog application.
Code coverage is reported by OpenCppCoverage for windows and by gcov for linux.
The code has been refactored to make it more readable and maintainable.
Some fixes has been made to the code to fix application crashes.

Signed-off-by: Vitalii Koshura <[email protected]>
…nto vko_remove_openssl_builtin_engines_and_add_tests
…l_builtin_engines_and_add_tests

Signed-off-by: Vitalii Koshura <[email protected]>

# Conflicts:
#	lib/crypt_prog.cpp
@Copilot Copilot bot review requested due to automatic review settings January 25, 2025 11:53

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • lib/crypt.cpp: Language not supported
Comments suppressed due to low confidence (2)

tests/crypt_prog_tests.py:145

  • The variable name 'type' is ambiguous and conflicts with the built-in 'type' function in Python. It should be renamed to 'key_type'.
def _convkey(self, mode, type, key_in, key_out):

tests/crypt_prog_tests.py:153

  • [nitpick] The error message could be more descriptive. Suggest changing to: 'Usage: python crypt_prog_tests.py <path_to_crypt_prog_executable>'.
print("Usage: python crypt_prog_tests.py <crypt_prog>")
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 64.63700% with 151 lines in your changes missing coverage. Please review.

Project coverage is 11.95%. Comparing base (df43b3f) to head (0bf7992).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
lib/crypt_prog.cpp 62.89% 145 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6022      +/-   ##
============================================
+ Coverage     10.70%   11.95%   +1.24%     
  Complexity     1068     1068              
============================================
  Files           280      280              
  Lines         36713    36974     +261     
  Branches       8513     8533      +20     
============================================
+ Hits           3930     4420     +490     
+ Misses        32394    32154     -240     
- Partials        389      400      +11     
Files with missing lines Coverage Δ
lib/crypt.cpp 54.38% <100.00%> (+54.38%) ⬆️
lib/crypt_prog.cpp 60.81% <62.89%> (+60.81%) ⬆️

... and 2 files with indirect coverage changes

@AenBleidd AenBleidd merged commit b7a9977 into master Jan 25, 2025
153 checks passed
@AenBleidd AenBleidd deleted the vko_remove_openssl_builtin_engines_and_add_tests branch January 25, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants