-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove OpenSSL built-in engines and add automation tests #6022
Remove OpenSSL built-in engines and add automation tests #6022
Conversation
The ENGINE API is deprecated in OpenSSL 3.0; the intended replacement is the Provider API. See also #5356, for which this addresses one (but not all) of the reported deprecation warnings.
Automation tests have been added for the crypt_prog application. Code coverage is reported by OpenCppCoverage for windows and by gcov for linux. The code has been refactored to make it more readable and maintainable. Some fixes has been made to the code to fix application crashes. Signed-off-by: Vitalii Koshura <[email protected]>
…nto vko_remove_openssl_builtin_engines_and_add_tests
…l_builtin_engines_and_add_tests Signed-off-by: Vitalii Koshura <[email protected]> # Conflicts: # lib/crypt_prog.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- lib/crypt.cpp: Language not supported
Comments suppressed due to low confidence (2)
tests/crypt_prog_tests.py:145
- The variable name 'type' is ambiguous and conflicts with the built-in 'type' function in Python. It should be renamed to 'key_type'.
def _convkey(self, mode, type, key_in, key_out):
tests/crypt_prog_tests.py:153
- [nitpick] The error message could be more descriptive. Suggest changing to: 'Usage: python crypt_prog_tests.py <path_to_crypt_prog_executable>'.
print("Usage: python crypt_prog_tests.py <crypt_prog>")
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6022 +/- ##
============================================
+ Coverage 10.70% 11.95% +1.24%
Complexity 1068 1068
============================================
Files 280 280
Lines 36713 36974 +261
Branches 8513 8533 +20
============================================
+ Hits 3930 4420 +490
+ Misses 32394 32154 -240
- Partials 389 400 +11
|
No description provided.