Test updated libmount library #6776
Conversation
Signed-off-by: Vitalii Koshura <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR adds vcpkg port configuration files for the libmount library version 2.41.3 from the util-linux package. The changes introduce build scripts to download, patch, configure, and install libmount and libblkid libraries on Linux systems.
- Adds vcpkg.json manifest defining the libmount port with version 2.41.3, Linux support, and optional NLS (native language support) feature
- Creates portfile.cmake with build instructions using autotools to configure and install the library
- Includes a patch to prevent symbol clashes with libsystemd by renaming private functions
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| 3rdParty/vcpkg_ports/ports/libmount/vcpkg.json | Defines the package metadata, version, platform support, and optional features for libmount |
| 3rdParty/vcpkg_ports/ports/libmount/portfile.cmake | Implements the build process: downloads source from kernel.org, applies patches, configures with autotools, and installs the libraries |
| 3rdParty/vcpkg_ports/ports/libmount/hide-private-symbols.diff | Patches util-linux to rename parse_size and parse_range functions to avoid conflicts with libsystemd |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "name": "libmount", | ||
| "version": "2.41.3", | ||
| "description": "Block device identification library from util-linux", |
There was a problem hiding this comment.
The description "Block device identification library from util-linux" is incorrect. This describes libblkid, not libmount. Libmount is a library for parsing /etc/fstab, /etc/mtab and /proc/self/mountinfo files, and for manipulating mount tables. The description should be updated to accurately reflect libmount's functionality, such as "Library to handle mount table parsing and manipulation".
| "description": "Block device identification library from util-linux", | |
| "description": "Library to handle mount table parsing and manipulation", |
| --- a/include/strutils.h | ||
| +++ b/include/strutils.h |
There was a problem hiding this comment.
The patch file has an incorrectly formatted line. Line 0 should be line 4 in the unified diff format. The correct format should show line 3 as '--- a/include/strutils.h' and line 4 as '+++ b/include/strutils.h'. The line marked as '0' disrupts the standard unified diff format and may cause patch application to fail.
| vcpkg_install_make() | ||
| vcpkg_fixup_pkgconfig() | ||
|
|
||
|
|
There was a problem hiding this comment.
There is an extra blank line here that should be removed. While not functionally significant, it's inconsistent with the formatting style used in similar port files in this repository.
Summary by cubic
Adds a Linux-only vcpkg port for util-linux 2.41.3 to build libmount and libblkid. This lets us consume these libraries via vcpkg.
Written for commit 0f9a751. Summary will update on new commits.