Skip to content

Conversation

@AenBleidd
Copy link
Member

@AenBleidd AenBleidd commented Jan 9, 2026

Summary by cubic

Adds a custom vcpkg port for Pango 1.57.0 with Meson build settings and a patch to relax gobject-introspection requirements for broader CI compatibility.

  • New Features
    • New vcpkg port: pango 1.57.0 (vcpkg.json, portfile.cmake).
    • Patch lowers gobject-introspection to >=1.82.0 and removes gi-docgen arg.
    • Meson: enable cairo/fontconfig/freetype; disable docs, man pages, tests, examples; optional introspection (off in Debug).
    • Installs tools (pango-view, pango-list, pango-segmentation) and fixes pkg-config files.

Written for commit bbb58ae. Summary will update on new commits.

Signed-off-by: Vitalii Koshura <[email protected]>
Copilot AI review requested due to automatic review settings January 9, 2026 07:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds vcpkg port configuration for the Pango library version 1.57.0, a text and font handling library used in the GNOME ecosystem. The PR introduces three new files to integrate Pango into the project's third-party dependency management system.

  • Adds vcpkg.json with Pango 1.57.0 package metadata and dependency specifications
  • Includes a patch to relax gobject-introspection version requirements for compatibility
  • Provides CMake-based portfile for building and installing Pango via vcpkg

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
3rdParty/vcpkg_ports/ports/pango/vcpkg.json Defines Pango package metadata, version 1.57.0, dependencies, and optional introspection feature
3rdParty/vcpkg_ports/ports/pango/relax-gi-requirement.diff Patches Pango to relax gobject-introspection requirement from 1.83.2 to 1.82.0 and removes doc-format flag
3rdParty/vcpkg_ports/ports/pango/portfile.cmake Configures the build process with meson, handles source download, patch application, and tool installation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

diff --git a/meson.build b/meson.build
index b8098c1..10033c8 100644
--- a/meson.build
+++ b/meson.build
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch file header has an incorrect number of plus signs. Standard unified diff format requires exactly three plus signs (+++), but this line has four (++++). This will cause the patch to fail when applied by standard patch tools. Change ++++ to +++.

Copilot uses AI. Check for mistakes.
diff --git a/pango/meson.build b/pango/meson.build
index f3c6d70..674b702 100644
--- a/pango/meson.build
+++ b/pango/meson.build
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch file header has an incorrect number of plus signs. Standard unified diff format requires exactly three plus signs (+++), but this line has four (++++). This will cause the patch to fail when applied by standard patch tools. Change ++++ to +++.

Copilot uses AI. Check for mistakes.
@AenBleidd AenBleidd closed this Jan 9, 2026
@AenBleidd AenBleidd deleted the vko_test_updated_pango branch January 9, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants