Update Esoterist Daemon's Hammer of Wrath based on their dominion #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can upload the files as a system directly to new recruit to test this Then test and upload some screenshots here so we can see :) |
|
Thanks @The4D6 I've uploaded screenshots of my fix working for the esoterist rainstorm daemon units. I need to look at why the Selenium Tests failed... but any hints would be appreciated |
|
Looks like the tests run on my fork ok when I synced with the origin. I think this change is good to go @The4D6 |
The4D6
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default each of the unit's hammer of wrath info name to "Hammer of Wrath (1)"
Hide the Hammer of Wrath rule unless the unit has the "infernal tempest" dominion
Change the brutes name to "Hammer of Wrath (2)" if they have the "infernal tempest dominion.
Setting the scope to Parent doesn't appear to work, I assume it's because the parent is the rule not the selection, so I tried using ancestor instead.
Added Units
N/A
Fixed Units
Related Issues
Not done yet
N/A
Test Case
Lesser Daemon
No Dominion (No Hammer of Wrath)
Infernal Tempest (Adds Hammer of Wrath)
Other Dominion (No Hammer of Wrath)
Beasts
No Dominion (No Hammer of Wrath)
Infernal Tempest (Adds Hammer of Wrath)
Other Dominion (No Hammer of Wrath)
Swarms
No Dominion (No Hammer of Wrath)
Infernal Tempest (Adds Hammer of Wrath)
Other Dominion (No Hammer of Wrath)
Brutes
No Dominion (Hammer of Wrath 1)
Infernal Tempest (Hammer of Wrath 2)
Other Dominion (Hammer of Wrath 1)