Implemented lil optimization - #25
Merged
Merged
Conversation
… 1 to 256 in order but becomes inconsistent beyond that.
…f each node on the fast path instead of the length of the fast path. Insert also no longer uses prefixMismatch to determine if a node can be inserted to the fast path and instead directly compares keys. The method canLilInsert was added to the QuArt_lil class to perform this check. The code now passes tests with 10000 sorted entries but struggles to complete execution with 100000 or more sorted entries, seemingly due to timeout.
…issues with updating the tree properly.
…t-lil-optimization-in-art
…ile has been deleted.
…a correct tree but queries for values above 255 return null.
…est on larger data collections with varying degrees of sortedness.
There was a problem hiding this comment.
Pull Request Overview
This PR implements optimization strategies for the Adaptive Radix Tree (ART) data structure by introducing "QuART" (Quick ART) variants with fast-path insertion mechanisms. The changes restructure the codebase to support multiple tree implementations and add new QuART variants that optimize insertion performance through different fast-path strategies.
Key changes include:
- Refactoring of ART node insertion methods to support different tree variants
- Implementation of QuART_lil and QuART_tail classes with optimized insertion paths
- Addition of benchmarking infrastructure and experimental evaluation tools
Reviewed Changes
Copilot reviewed 15 out of 18 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| trees/QuART_tail.h | New QuART variant implementing tail-based fast path optimization |
| QuART_lil.h | New QuART variant implementing "lil" (likely "last in line") fast path optimization |
| ArtNode_lil.h | Node insertion methods for the lil optimization variant |
| ArtNodeNewMethods.cpp | Tail-specific insertion methods for QuART_tail variant |
| ART.h | Enhanced base ART class with fast path fields and verification methods |
| ArtNode.h | Refactored to remove insertion method definitions and fix method signatures |
| run.cpp | New benchmarking executable for comparing tree variants |
| run_experiments.sh | Automation script for running comprehensive experiments |
| main.cpp | Updated to use QuART_lil by default and modernized loop variables |
| test_range_query.cpp | Fixed rangelookup method call signature |
| Helper.h | Added integer-to-array conversion utilities |
| Chain.h | Fixed logical operator in range query functionality |
| CMakeLists.txt | Updated build configuration for new executables |
Comments suppressed due to low confidence (1)
…t-lil-optimization-in-art
Updated variable type Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Updated variable type Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Updated variable type Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Removed self-referencing variable initialization. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Updated arrToInt parameters Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
Also update run.cpp, run_experiments.sh and README to include lil |
cangokmen
requested changes
Jul 25, 2025
cangokmen
left a comment
cangokmen
left a comment
Contributor
There was a problem hiding this comment.
Added some comments, lmk if you have any questions or other ideas
…:BU-DiSC/Qu-ART into noahpk/implement-lil-optimization-in-art
Collaborator
|
Moving the PR from draft status into |
ramananeesh
marked this pull request as ready for review
July 26, 2025 02:03
ramananeesh
requested changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed files: ArtNode.h, ART.h
Created files: QuART_lil.h, ArtNode_lil.h
ArtNode.h: Removed definitions of insertNodeX methods to avoid circular dependencies across files.
ART.h: Added generic fast path fields to ART class.
QuART_lil.h: Implemented QuART class with lil inserts.
ArtNode_lil.h: Added insertNodeX functions removed from ArtNode.h and modified them to also follow lil logic.