Implemented fp reset - #32
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a stail reset mechanism for QuART trees to handle stale inserts by periodically forcing frontier pointer (fp) changes when non-bridge inserts accumulate.
Key changes:
- Introduces
QuART_stail_resetclass with a counter-based reset mechanism that forces fp updates after 300 stale inserts - Modifies
QuART_stailto expose protected recursive insert methods for inheritance - Adds support for the new tree type in the benchmark runner
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| trees/QuART_stail_reset.h | New class implementing stail tree with periodic fp resets via counter mechanism |
| trees/QuART_stail.h | Changed visibility of recursive insert methods from private to protected |
| run.cpp | Added benchmark support for QuART_stail_reset tree type |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added files: trees/QuART_stail_reset.h
Updated files: run.cpp, trees/QuART_stail.h