Skip to content

Implemented fp reset - #32

Merged
cangokmen merged 5 commits into
mainfrom
cangokmen/stail_reset_implementation
Oct 27, 2025
Merged

Implemented fp reset#32
cangokmen merged 5 commits into
mainfrom
cangokmen/stail_reset_implementation

Conversation

@cangokmen

@cangokmen cangokmen commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Added files: trees/QuART_stail_reset.h
Updated files: run.cpp, trees/QuART_stail.h

  • trees/QuART_stail_reset.h: Implements a separate stail tree that supports fp pointer resets when the fp pointer goes stale. It is a child of the QuART_stail class.
  • trees/QuART_stail.h: Made recursive insert functions protected so that QuART_stail_reset can use them.
  • run.cpp: Added QuART_stail_reset as a tree option.

@cangokmen cangokmen self-assigned this Oct 21, 2025
@cangokmen cangokmen added the enhancement New feature or request label Oct 21, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a stail reset mechanism for QuART trees to handle stale inserts by periodically forcing frontier pointer (fp) changes when non-bridge inserts accumulate.

Key changes:

  • Introduces QuART_stail_reset class with a counter-based reset mechanism that forces fp updates after 300 stale inserts
  • Modifies QuART_stail to expose protected recursive insert methods for inheritance
  • Adds support for the new tree type in the benchmark runner

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
trees/QuART_stail_reset.h New class implementing stail tree with periodic fp resets via counter mechanism
trees/QuART_stail.h Changed visibility of recursive insert methods from private to protected
run.cpp Added benchmark support for QuART_stail_reset tree type

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cangokmen cangokmen changed the title Implemented stail reset Implemented fp reset Oct 21, 2025

@ramananeesh ramananeesh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cangokmen
cangokmen merged commit 678f977 into main Oct 27, 2025
1 check passed
@cangokmen
cangokmen deleted the cangokmen/stail_reset_implementation branch October 27, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants