Support KHR_materials_coat extension #17360
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17360/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17360/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17360/merge#BCU1XR#0 |
|
Devhost visualization test reporter: |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
Devhost visualization test reporter: |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
| * @returns A new, internal texture with the coat weight in the red channel and coat roughness in the green channel | ||
| * @internal | ||
| */ | ||
| async function CreateMergedCoatInternalTexture(babylonMaterial: OpenPBRMaterial): Promise<Nullable<InternalTexture>> { |
There was a problem hiding this comment.
nit: we usually put Async postfix for async functions as a convention
| async function CreateMergedCoatInternalTexture(babylonMaterial: OpenPBRMaterial): Promise<Nullable<InternalTexture>> { | |
| async function CreateMergedCoatInternalTextureAsync(babylonMaterial: OpenPBRMaterial): Promise<Nullable<InternalTexture>> { |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
Devhost visualization test reporter: |
Head branch was pushed to by a user without write access
|
Devhost visualization test reporter: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
5 participants
Adding support to import and export
KHR_materials_coat, the new coating extension for glTF that supports additional features like coat color, coat darkening and coat anisotropy.I also removed the previous sub-extensions that I had added recently (e.g. KHR_materials_clearcoat_darkening, etc.) as they are no longer needed.
I also used the texture merger to combine the coat weight and coat roughness textures, if needed.