Ontmoetingsformulier changes#611
Conversation
- added encounterID as foreign key on comments, to add comments directly to ontmoetingsformulier - added input new input types for games, comments and encounter competitions
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
ik heb de Contributor Licentie Overeenkomst gelezen en verklaar mij hiermee akkoord |
|
recheck |
roberttullycarr
changed the base branch from
develop
to
pandapanda_development
| linkType: newCommentData.linkType, | ||
| clubId: newCommentData.clubId, | ||
| ...(newCommentData.clubId ? {clubId: newCommentData.clubId} : {}), | ||
| ...(newCommentData.encounterId ? {encounterId: newCommentData.encounterId} : {}), |
There was a problem hiding this comment.
same here, this value should be filled in on linkId
There was a problem hiding this comment.
Yeah, the goal here was to create a game leader comment, but it would be much better to add it as a new link type. I didn't know a game leader was definitely a part of the home team, so my thought was the game leader wouldn't have a valid club id. I will change this
| gameId: game.id, | ||
| team: player.team, | ||
| player: player.player, | ||
| systemId: player.systemId, |
There was a problem hiding this comment.
system can be globally, and maybe even fetched here (so not passed from the client)
There was a problem hiding this comment.
So what are you suggesting I do here? In our app, we are passing this from the frontend
|
|
||
| if (gameData.players) { | ||
| for (const player of gameData.players) { | ||
| await GamePlayerMembership.create({ |
There was a problem hiding this comment.
Ranking for singles,doubles,mix are missing in the membership
There was a problem hiding this comment.
Should this data should be coming from the RankingLastPlaces table? at the time I wrote this, I had no clue how that data was being generated
|
|
||
| // if game is not a draw, update the score of the encounter | ||
| if (gameData.winner !== 0){ | ||
| await encounter.update({ |
There was a problem hiding this comment.
I'm assuming here a game is worth one point for the winning team? it seems that way from the data we have, but i'm not at all sure that's the case
…ility to get games of draw competition
Ontmoetingsformulier changes
2 participants
No description provided.