Skip to content

Fix: Improve DSC error handling#801

Merged
FlorianGille merged 2 commits intodevelopfrom
fix/handle-dsc-errors
May 17, 2024
Merged

Fix: Improve DSC error handling#801
FlorianGille merged 2 commits intodevelopfrom
fix/handle-dsc-errors

Conversation

@ntatoud
Copy link
Copy Markdown
Collaborator

@ntatoud ntatoud commented May 17, 2024

Description of changes

  1. Send a feedback to the client when trying to create a campaign on DSC with a name that is already take
    => Throw the error caught when doing the POST creation request

  2. When updating a campaign for a dsc profile, if the campaign was deleted on dsc, the user would not be able to make any change to this campaign.
    Instead, switch to creation mode and allow the user to create a new campaign for this mail and dsc profile.
    => On the Front end, instead of displaying the not found error, catch it and switch to update mode

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@FlorianGille FlorianGille merged commit d0ab478 into develop May 17, 2024
@FlorianGille FlorianGille deleted the fix/handle-dsc-errors branch May 17, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants