Skip to content

Ch unit tests for trips 167809154 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Baraka-Mugisha wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Ch unit tests for trips 167809154 #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
395a692
chore(tripTests): adds unit tests for trips [Finishes #167809154]
Baraka-Mugisha Aug 9, 2019
98d670d
chore(tripTests): Adds tests for trip controllers [Finishes #67809154]
Baraka-Mugisha Aug 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions server/controllers/bookingController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,14 @@ const bookingController = {
const user = database.users.find(user => user.email == tokens.decoded(req, res).email);
if (user) {
let { trip_id } = req.body;
const result = Joi.validate({ trip_id }, schema.trips);
const result = Joi.validate({ trip_id }, schema.bookings);
if (result.error) {
return res.status(400).json({ status: 400, message: `${result.error.details[0].message}` });

};
const trip = database.trips.find(trip => trip.id == trip_id);

if (!trip) {; return res.status(404).json({ status: 404, message: "the trip to book was not found" }) };
if (!trip) { return res.status(404).json({ status: 404, message: "the trip to book was not found" }) };

const newBooking = {
trip_id: trip.id,
Expand All @@ -75,9 +75,10 @@ const bookingController = {
user_email: user.email,
createdon: moment().format('ll'),
}
if (trip.seats_left < 1) { return res.status(404).json({ status: 404, message: "There are no seats left on tthis trip" }) };
database.bookings.push(newBooking);
database.trips.find(trip => trip.id == newBooking.trip_id).seats_left -= 1;
if (trip.seats_left < 1) { return res.status(404).json({ status: 404, message: "There are no seats left on this trip" }) };
database.bookings.push(newBooking);

return res.status(201).json({ status: 201, message: "Booking created", data: newBooking })
}
return res.status(401).json({ status: 401, message: "You are unauthorized for this operation. Sign in first" });
Expand Down
4 changes: 3 additions & 1 deletion server/controllers/tripController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const tripController = {
},
getSpecificTrip(req, res) {
const user = database.users.find(user => user.email == tokens.decoded(req, res).email);
console.log(tokens.decoded(req, res));

const id = req.params.trip_id;
const trip = database.trips.find(trip => trip.id === parseInt(id, 10));

Expand All @@ -47,7 +47,9 @@ const tripController = {

database.trips.find(trip => trip.id === parseInt(id, 10)).status = "cancelled";
return res.status(200).json({ status: 200, message: "Trip cancelled successfully", data: database.trips.find(trip => trip.id === parseInt(id, 10)) });

}
return res.status(401).json({ status: 401, message: "You are not registered as an admin" });
};

return res.status(401).json({ status: 401, message: "You are unauthorized to access trips... You are not yet registered" });
Expand Down
19 changes: 11 additions & 8 deletions server/middlewares/validation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,17 @@ const schema = {

}),
trips: Joi.object().keys({
trip_id: Joi.number().required(),
origin: Joi.string().min(3).max(30),
destination: Joi.string().min(3).max(30),
trip_date: Joi.date(), // .format('DD-MM-YYYY').
fare: Joi.number(),
bus_license_number: Joi.string().regex(/^[a-zA-Z0-9 ]*$/),
seating_capacity: Joi.number().min(10).max(120),
status: Joi.string().valid('active', 'cancelled')
trip_id: Joi.number(),
origin: Joi.string().min(3).max(30).required(),
destination: Joi.string().min(3).max(30).required(),
trip_date: Joi.date().required(), // .format('DD-MM-YYYY').
fare: Joi.number().required(),
bus_license_number: Joi.string().regex(/^[a-zA-Z0-9 ]*$/).required(),
seating_capacity: Joi.number().min(10).max(120).required(),
status: Joi.string().valid('active', 'cancelled'),
}),
bookings: Joi.object().keys({
trip_id: Joi.number().required()
})
};

Expand Down
249 changes: 249 additions & 0 deletions server/tests/tripTests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,249 @@
import mocha from 'mocha';
import chai from 'chai';
import chaiHttp from 'chai-http';
import app from '../app';
import tokens from '../helpers/tokens';

chai.use(chaiHttp);
chai.should();

const admin_payload = {
id: 1,
email: 'baraka@gmail.com',
first_name: 'baraka',
last_name: 'jean'
};
const user_payload = {
id: 2,
email: 'jean@gmail.com',
first_name: 'jean',
last_name: 'pierre'
};
const nau_payload = {
id: 432,
email: 'email@mail.org',
first_name: 'notauser',
last_name: 'peter'
}
const token = tokens.getToken(user_payload);
const tokenNAU = tokens.getToken(nau_payload);
const tokenAd = tokens.getToken(admin_payload);

describe('before each', () => {
beforeEach((done) => {
done();
})
})
describe('Trip tests', () => {

it('should be able to view specific trip when he is a user', () => {
chai.request(app).get("api/v1/trips/1")
.set('authorization', `Bearer ${token}`)
.end((err, res) => {
res.should.has.status(200);
done();
})
});
it('should be able to view specific trip when he is an admin', () => {
chai.request(app).get("api/v1/trips/1")
.set('authorization', `Bearer ${tokenAd}`)
.end((err, res) => {
res.should.has.status(200);
done();
})
});
it('should not be able to view specific trip when he is not a user', () => {
chai.request(app).get("api/v1/trips/1")
.set('authorization', `Bearer ${tokenNAU}`)
.end((err, res) => {
res.should.has.status(401);
done();
})
});


it('should be able to view all trips when he is a user', () => {
chai.request(app).get("api/v1/trips")
.set('authorization', `Bearer ${token}`)
.end((err, res) => {
res.should.has.status(200);
done();
})
});
it('should be able to view all trips when he is an admin', () => {
chai.request(app).get("api/v1/trips")
.set('authorization', `Bearer ${tokenAd}`)
.end((err, res) => {
res.should.has.status(200);
done();
})
});
it('should not be able to view all trips when he is not a user', () => {
chai.request(app).get("api/v1/trips")
.set('authorization', `Bearer fsdfsfgdhrefs`)
.end((err, res) => {
res.should.has.status(401);
done();
})
});
it('should not be able to view specific trip which does not exist', () => {
chai.request(app).get("api/v1/trips/23")
.set('authorization', `Bearer ${token}`)
.end((err, res) => {
res.should.has.status(404);
done();
})
});
it('should be able to view an existing trip', () => {
chai.request(app).get("api/v1/trips/1")
.set('authorization', `Bearer ${token}`)
.end((err, res) => {
res.should.has.status(200);
done();
})
});

it('should not be able to view a non existing trip', () => {
chai.request(app).get("api/v1/trips/1234")
.set('authorization', `Bearer ${token}`)
.end((err, res) => {
res.should.has.status(404);
done();
})
});

//for cancelling a trip
it('should be able to cancel trip when he is an admin', () => {
chai.request(app).patch("api/v1/trips/1/cancel")
.set('authorization', `Bearer ${tokenAd}`)
.end((err, res) => {
res.should.has.status(200);
done();
})
});
it('should not be able to cancel trip when he is a user', () => {
chai.request(app).patch("api/v1/trips/1/cancel")
.set('authorization', `Bearer ${token}`)
.end((err, res) => {
res.should.has.status(401);
done();
})
});
it('should not be able to cancel trip when he is not a user', () => {
chai.request(app).patch("api/v1/trips/1/cancel")
.set('authorization', `Bearer ${tokenNAU}`)
.end((err, res) => {
res.should.has.status(401);
done();
})
});
it('should not be able to cancel trip which does not exist', () => {
chai.request(app).patch("api/v1/trips/3545/cancel")
.set('authorization', `Bearer ${token}`)
.end((err, res) => {
res.should.has.status(404);
done();
})
});
//for creating a new trip
it('should not be able to create trip when he is not an admin', () => {
chai.request(app).post("api/v1/trips")
.send({
origin: "kigali",
destination: "musanze",
seating_capacity: "50",
trip_date: "5090",
fare: "400",
bus_license_number: "RAB 483A",
})
.set('authorization', `Bearer ${token}`)
.end((err, res) => {
res.should.has.status(401);
done();
})
});
it('should not be able to create trip when origin is empty', () => {
chai.request(app).post("api/v1/trips")
.send({
origin: "",
destination: "musanze",
seating_capacity: "50",
trip_date: "5090",
fare: "400",
bus_license_number: "RAB 483A",
})
.set('authorization', `Bearer ${tokenAd}`)
.end((err, res) => {
res.should.has.status(400);
done();
})
});
it('should not be able to create trip when destination is empty', () => {
chai.request(app).post("api/v1/trips")
.send({
origin: "rubavu",
destination: "",
seating_capacity: "50",
trip_date: "5090",
fare: "400",
bus_license_number: "RAB 483A",
})
.set('authorization', `Bearer ${tokenAd}`)
.end((err, res) => {
res.should.has.status(400);
done();
})
});
it('should not be able to create trip when fare is empty', () => {
chai.request(app).post("api/v1/trips")
.send({
origin: "rubavu",
destination: "kigali",
seating_capacity: "50",
trip_date: "5090",
fare: "",
bus_license_number: "RAB 483A",
})
.set('authorization', `Bearer ${tokenAd}`)
.end((err, res) => {

res.should.has.status(400);
done();
})
});
it('should not be able to create trip when bus_license_number is empty', () => {
chai.request(app).post("api/v1/trips")
.send({
origin: "rubavu",
destination: "kigali",
seating_capacity: "50",
trip_date: "5090",
fare: "230",
bus_license_number: "",
})
.set('authorization', `Bearer ${tokenAd}`)
.end((err, res) => {

res.should.has.status(400);
done();
})
});
it('should not be able to create trip when fare is empty', () => {
chai.request(app).post("api/v1/trips")
.send({
origin: "rubavu",
destination: "kigali",
seating_capacity: "50",
trip_date: "5090",
fare: "",
bus_license_number: "RAB 483A",
})
.set('authorization', `Bearer ${tokenAd}`)
.end((err, res) => {

res.should.has.status(400);
done();
})
});

})
Loading