Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicting keys on dynamic zone #31

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Freyb
Copy link

@Freyb Freyb commented Apr 25, 2023

As was described in #28 if multiple components share the same attribute name in a dynamic zone, components that are higher on the component list might not get their attributes populated.

Strapi provides two way to populate dynamic zones. As described by the docs:

When populating dynamic zones, you can choose between:

  • a shared population strategy, applying a unique behavior for all the dynamic zone's components
  • or a detailed population strategy, defining per-component populate queries using the on property.

https://docs.strapi.io/dev-docs/api/rest/populate-select#components--dynamic-zones

This PR fixes this issue by utilizing the on keyword in dynamic components

@Levy-from-Odessa
Copy link

Great fix, Thanks
@Barelydead could you merge it, pls?

@Freyb
Copy link
Author

Freyb commented Jun 14, 2023

@Barelydead Could you check it and merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants