Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new theme - Inretio #2247

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Add new theme - Inretio #2247

merged 5 commits into from
Nov 6, 2024

Conversation

gytisrepecka
Copy link
Contributor

Add new theme called Inretio, along with documentation describing it.

Description

Inretio theme uses inspiration from existing themes: metal and bobby, but adds more details about virtual environment - when Python is available in it, prompt will display that particular Python binary version.

Motivation and Context

Displaying specific Python version is very useful for developers who keep multiple venvs for running their Python code on different runner versions, e.g.: 3.12.x and 3.9.x on the same machine.

How Has This Been Tested?

Tested on usual filesystem folder, Git-tracked folder, in venv without Python and in venv with Python.

Screenshots (if appropriate):

Added in documentation as required: #2246

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gytisrepecka
Copy link
Contributor Author

gytisrepecka commented Mar 20, 2024

It looks like there is an error in linter:

Bash include file themes/inretio/inretio.theme.bash has bad/missing shellcheck header

Because following is indeed the recommended shebang to properly find BASH location:

#!/usr/bin/env bash

Edit: not related to shebang - actually theme file needed following on top of it:

# shellcheck shell=bash
# shellcheck disable=SC2034 # Expected behavior for themes.

@gytisrepecka
Copy link
Contributor Author

Currently have no idea what Linter wants me to fix. Is there a usable documentation to understand and troubleshoot Linter issues?

Current documentation hardly helps 🧐

Copy link
Contributor

@seefood seefood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

@seefood seefood merged commit 0375b77 into Bash-it:master Nov 6, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants