Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring to compliance all the completions #2284

Merged
merged 23 commits into from
Feb 1, 2025
Merged

Bring to compliance all the completions #2284

merged 23 commits into from
Feb 1, 2025

Conversation

seefood
Copy link
Contributor

@seefood seefood commented Jan 29, 2025 •
edited
Loading

running all the pre-commit tests on the completions and fixing them one by one.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@seefood seefood self-assigned this Jan 29, 2025
@seefood seefood marked this pull request as ready for review February 1, 2025 09:48
akinomyoga
akinomyoga reviewed Feb 1, 2025
View reviewed changes
@seefood seefood force-pushed the ira/cleanup6-completions branch from 30e57ea to 1010f41 Compare February 1, 2025 13:04
seefood and others added 19 commits February 1, 2025 15:25
@seefood @akinomyoga
bring to compliance: tmux.completion
fc623c5 
Co-authored-by: Koichi Murase <[email protected]>
@seefood
bring to compliance: maven.completion
e0ceb94
@seefood
bring to compliance: terraform.completion
aaf21e4
@seefood
bring to compliance: test_kitchen.completion
840c8fd
@seefood
bring to compliance: git_flow.completion
b7e7557
@seefood
bring to compliance: git_flow_avh.completion
9c2edda
@seefood
clean up AWS plugin
761054d
@seefood
Cleanup all remaining plugins
fbd0429
@seefood
last details
d3a68c8
@seefood
bring to compliance: rake.completion
0386181
@seefood
bring to compliance: projects.completion
16fcc2a
@seefood
bring to compliance: nvm.completion
ba6afac
@seefood
bring to compliance: ng.completion
2f70354
@seefood
bring to compliance: kind.completion
937d1af
@seefood
bring to compliance: gulp.completion
8160145
@seefood
bring to compliance: grunt.completion
4e263f6
@seefood
bring to compliance: hub.completion
db985f0 
Update completion/available/hub.completion.bash

Co-authored-by: Koichi Murase <[email protected]>

make the comparisons more elegant and save an invokation of an external bin
@seefood
bring to compliance: invoke.completion
3722758
@seefood
bring to compliance: ssh.completion
6a2d699
@seefood seefood force-pushed the ira/cleanup6-completions branch from 1010f41 to 6a2d699 Compare February 1, 2025 13:26
akinomyoga
akinomyoga reviewed Feb 1, 2025
View reviewed changes
seefood and others added 3 commits February 1, 2025 15:31
@seefood @akinomyoga
Update completion/available/maven.completion.bash
9c78f5c 
Co-authored-by: Koichi Murase <[email protected]>
@seefood
Last few fixes after consulting Koichi-san.
f4f3b14
@seefood
Merge branch 'ira/cleanup6-completions' of github.com:Bash-it/bash-it…
9f3cf40 
… into ira/cleanup6-completions

* 'ira/cleanup6-completions' of github.com:Bash-it/bash-it:
  Update completion/available/maven.completion.bash
@seefood seefood merged commit 081457e into master Feb 1, 2025
13 checks passed
@seefood seefood deleted the ira/cleanup6-completions branch February 1, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akinomyoga akinomyoga akinomyoga approved these changes

Assignees

@seefood seefood

Labels
clean up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seefood @akinomyoga