Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check whether dnf command exists before aliasing #2286

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

shinenelson
Copy link
Contributor

@shinenelson shinenelson commented Feb 7, 2025

Description

Enclose the aliases for dnf within the _command_exists helper function.

Motivation and Context

We do not need to add aliases for package managers if the command does not exist.

This was done for other files that were already checking for commands via command -v in #1938.

How Has This Been Tested?

Tested by syncing profiles between Debian, Fedora and macos

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Copy link
Contributor

@seefood seefood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@seefood seefood merged commit d8eafdd into Bash-it:master Feb 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants