Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in "Adding Uncertainty over Model Parameters" section of the tutorial #546

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

michaelleejl
Copy link
Contributor

@michaelleejl michaelleejl commented Jun 20, 2024

In Adding Uncertainty over Model Parameters, (https://basisresearch.github.io/chirho/tutorial_i.html#Adding-Uncertainty-over-Model-Parameters), the following code snippet

def bayesian_population_causal_model(n_individuals):
    stress_prob, smokes_cond_prob, cancer_cond_prob = parameter_prior()
    return population_intervened_causal_model(
        n_individuals, stress_prob, smokes_cond_prob, cancer_cond_prob
    )

Calls population_intervened_causal_model. It should instead call population_causal_model.

@eb8680 eb8680 added bug Something isn't working status:awaiting review Awaiting response from reviewer examples module:counterfactual labels Jun 20, 2024
@eb8680 eb8680 self-requested a review June 20, 2024 17:09
Copy link
Contributor

@eb8680 eb8680 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@eb8680 eb8680 merged commit eb673eb into BasisResearch:master Jun 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working examples module:counterfactual status:awaiting review Awaiting response from reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants