Jail autocomplete function - testing required#758
Closed
tschettervictor wants to merge 22 commits intoBastilleBSD:masterfrom
Closed
Jail autocomplete function - testing required#758tschettervictor wants to merge 22 commits intoBastilleBSD:masterfrom
tschettervictor wants to merge 22 commits intoBastilleBSD:masterfrom
Conversation
Collaborator
Author
|
With this current code, the autocomplete function is only called if the jails directory is not detected. The function will then proceed to check the directory, and if not found it will exit. If it find multiple directories, it will exist informing the user of multiple choices. If only one is found, it will set it as the TARGET. |
Collaborator
Author
|
@bmac2 Not sure where I can view the shellcheck errors. Usually they are listed right inside the file... |
Collaborator
Author
|
Ive added some shellcheck bypasses for the following reasons.
|
Collaborator
Author
|
Closing this. There will be a better way to implement this in a future version if PR #776 is accepted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've rewritten the autocomplete function to be a little easier to follow.
These are the key points.
When testing, please try to use every single command that is directed toward a jail, and let me know if it works properly or not.