-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ;; #780
Add ;; #780
Conversation
@yaazkal Can you test this one? I somehow forgot a ;; at the end of the case command. |
I assume this is supposed to be exactly like #770 with the one line fix, but this one is missing other lines that were in 770. I am confused. Is the else line needed or not? |
Yes. That line is at the end of every case command. I'm not sure why the checks aren't catching it. |
Out maybe it dude need to be present in a catch all case command. Are you seeing the same error as @yaazkal ? |
no I am just comparing the two PRs and there are other lines in 770. Specifically a line with: |
the ;; I get and understand |
Else is missing? Can you point it out? |
this one now tests fine for me. Tested template in normal place, then a template sitting in /tmp for the other test. Worked through it with @tschettervictor so this one needs another round of testing @yaazkal |
I have tested this and dosen't break anything. Now, I still agree to what @tschettervictor said in the previous PR:
If you still want to continue with this PR, it will need documentation so the user dosen't get unexpected behavior or you can consider adding a flag to explicitly tell the system to use the current folder to look for templates. I guess this will be confusing. |
I'll close it. Let's leave it as is for now. |
No description provided.