Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow refreshing of the token when we don't have a user #48

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

NiallBunting
Copy link
Contributor

Description

This doesn't fix the user being logged out (#47) but does allow updating of a refresh token without already having a user logged in.

This allows my work around to work without having to have a custom version of this library.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link
Member

@ahmednfwela ahmednfwela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

@ahmednfwela
Copy link
Member

can you please rename the pr to start with "fix: "

@NiallBunting NiallBunting changed the title Allow refreshing of the token when we don't have a user fix: Allow refreshing of the token when we don't have a user Jan 23, 2024
@NiallBunting
Copy link
Contributor Author

Updated :)

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8c068e2) 32.38% compared to head (f05929e) 15.02%.
Report is 6 commits behind head on main.

Files Patch % Lines
packages/oidc/lib/src/managers/user_manager.dart 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #48       +/-   ##
===========================================
- Coverage   32.38%   15.02%   -17.36%     
===========================================
  Files          43        4       -39     
  Lines        1260      406      -854     
===========================================
- Hits          408       61      -347     
+ Misses        852      345      -507     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahmednfwela ahmednfwela self-assigned this Jan 23, 2024
@ahmednfwela ahmednfwela merged commit 4e9fbac into Bdaya-Dev:main Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants