Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Query parameter serialization #60

Merged
merged 10 commits into from
Mar 13, 2024

Conversation

ahmednfwela
Copy link
Member

Description

Fixes #59

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 32.37%. Comparing base (c907443) to head (583eba2).

Files Patch % Lines
packages/oidc_desktop/lib/src/oidc_desktop.dart 0.00% 3 Missing ⚠️
packages/oidc_core/lib/src/utils.dart 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   32.00%   32.37%   +0.37%     
==========================================
  Files          44       43       -1     
  Lines        1275     1254      -21     
==========================================
- Hits          408      406       -2     
+ Misses        867      848      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahmednfwela ahmednfwela merged commit 521f94d into main Mar 13, 2024
20 checks passed
@ahmednfwela ahmednfwela deleted the fix/query-parameter-serialization branch March 13, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant