fix: Enforce UTF-8 encoding in response body parsing #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I got an issue of a wrong character encoding in the response from the userinfo endpoint when the user name contains non-ASCII characters.
This stems from the fact that http library falls back to latin encoding (
http-1.2.0/lib/src/utils.dart:encodingForCharset
) when theContent-Type
header in the userinfo response only saysapplication-json
instead ofapplication-json; charset=utf-8
. However utf-8 is the default forapplication/json
so oidc library should handle this gracefully ;-)Type of Change