Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logout options not being used #84

Merged
merged 3 commits into from
Jun 8, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/oidc_core/lib/src/managers/user_manager_base.dart
Original file line number Diff line number Diff line change
@@ -137,6 +137,14 @@ abstract class OidcUserManagerBase {
required OidcMonitorSessionStatusRequest request,
});

OidcPlatformSpecificOptions getOptions(
OidcPlatformSpecificOptions? optionsOverride,
) {
return optionsOverride ??
settings.options ??
const OidcPlatformSpecificOptions();
}

/// Attempts to login the user via the AuthorizationCodeFlow.
///
/// [originalUri] is the uri you want to be redirected to after authentication is done,
@@ -163,7 +171,7 @@ abstract class OidcUserManagerBase {
ensureInit();
final discoveryDocument =
discoveryDocumentOverride ?? this.discoveryDocument;
options ??= settings.options ?? const OidcPlatformSpecificOptions();
options = getOptions(options);
final simpleReq = OidcSimpleAuthorizationCodeFlowRequest(
clientId: clientCredentials.clientId,
originalUri: originalUri,
@@ -377,7 +385,7 @@ abstract class OidcUserManagerBase {
ensureInit();
final discoveryDocument =
discoveryDocumentOverride ?? this.discoveryDocument;
options ??= const OidcPlatformSpecificOptions();
options = getOptions(options);
final currentUser = this.currentUser;
if (currentUser == null) {
return;