improve first page + fix bugs #21
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| }, | ||
| { | ||
| title: 'Theme support', | ||
| // Svg: require('@site/static/img/undraw_docusaurus_tree.svg').default, |
There was a problem hiding this comment.
pourquoi c'est commenté ? a retirer ?
| title: 'Style props', | ||
| // Svg: require('@site/static/img/undraw_docusaurus_mountain.svg').default, | ||
| description: ( | ||
| <> |
| title: 'Chakra UI and React Native components', | ||
| // Svg: require('@site/static/img/undraw_docusaurus_react.svg').default, | ||
| description: ( | ||
| <> |
| import ExpoLayout from '../ExpoLayout/index.js'; | ||
| export const SimpleFeature = ({ title, description, code, codetitle }) => { | ||
| return ( |
There was a problem hiding this comment.
| import ExpoLayout from '../ExpoLayout/index.js'; | |
| export const SimpleFeature = ({ title, description, code, codetitle }) => { | |
| return ( | |
| import ExpoLayout from '../ExpoLayout/index.js'; | |
| export const SimpleFeature = ({ title, description, code, codetitle }) => { | |
| return ( |
| {item != 'Theme' ? ( | ||
| <img | ||
| src={themeimage} | ||
| className={styles.img} | ||
| alt="Color degradation" | ||
| style={{ objectFit: 'cover' }} | ||
| /> | ||
| ) : ( | ||
| <div> | ||
| <ThemesTable /> | ||
| </div> | ||
| )} | ||
| </div> |
There was a problem hiding this comment.
ici je prefere la logique inverse
item ==='theme' ? themeTable : img
| <div className={clsx('col col--4')} > | ||
|
|
||
| <div className="text--center padding-horiz--md padding-vert--md"> | ||
| <feature.icon size={30} strokeWidth={1} /> |
There was a problem hiding this comment.
| <feature.icon size={30} strokeWidth={1} /> | |
| <feature.icon size={30} strokeWidth={1} /> |
Tu n'as pas l'extension prettier qui formatte ton code ?
| @@ -49,10 +63,11 @@ export default function HomepageFeatures() { | |||
| return ( | |||
| <section className={styles.features}> | |||
| <div className="container"> | |||
| <div className="row"> | |||
| <div className="row "> | |||
There was a problem hiding this comment.
| <div className="row "> | |
| <div className="row"> |
idem la il te faut prettier
docs/src/pages/index.js
Outdated
| @@ -23,6 +23,7 @@ function HomepageHeader() { | |||
| </Link> | |||
| </div> | |||
| <p style={{fontSize: 20, fontWeight: 'bold', marginTop: 20}}>🎉 Beta version available ! 🎉</p> | |||
| <p style={{fontWeight:'bold'}}>Currently v1.0.0-beta7</p> | |||
There was a problem hiding this comment.
si on affiche la verison a plusieurs endroit ca sera interessant de l'etraire en constante générale pour tout le site comme ca on change qu'a un endroit
| .TryItLiveDescription { | ||
| display: flex; | ||
| flex-wrap: wrap; | ||
| } | ||
| .img { | ||
| padding-bottom: 10px; | ||
| height: min-content; | ||
| } | ||
| .TryItLiveDescription { | ||
| width: 100%; | ||
| } |
There was a problem hiding this comment.
on peut pas regrouper ensemble TryItLiveDescription ?
| import useBaseUrl from '@docusaurus/useBaseUrl'; | ||
| import isInternalUrl from '@docusaurus/isInternalUrl'; | ||
| import IconExternalLink from '@theme/Icon/ExternalLink'; | ||
| import * as Icons from 'react-icons/fa' |
There was a problem hiding this comment.
on peut pas faire mieux qu'importer TOUTES les icones ?
There was a problem hiding this comment.
Je n'ai pas trouvé de solution pour effectuer un import dynamique de ces icônes, donc j'ai essayé une autre approche. Merci de vérifier cela. Si vous avez une autre idée pour ce cas, je suis ouvert à la discussion.
There was a problem hiding this comment.
Il faut que la props icon soit un react Element donc en gros tu passes directement l'icone () en props comme ca c'est quand tu utilise "FooterLinkItem" que tu importes l'icone
houssembaltii
changed the title
bug cause : getstarted is linked to the sidebar that is auto generated (contains all routes ), it is designed to have active link class whenever an element from the sidebar is active so it's always active