Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve output from ignore commands #1212

Merged
merged 1 commit into from
Aug 25, 2023
Merged

fix: improve output from ignore commands #1212

merged 1 commit into from
Aug 25, 2023

Conversation

gotbadger
Copy link
Contributor

Description

Improve the output from ignore commands

  • format json so file is more friendly
  • beautify display of ignored entries
  • show new ignored entry on add

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@gotbadger gotbadger requested a review from elsapet August 25, 2023 15:13
elsapet
elsapet approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@elsapet elsapet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

pkg/util/ignore/ignore.go Show resolved Hide resolved
@gotbadger gotbadger merged commit f024b67 into main Aug 25, 2023
7 checks passed
@gotbadger gotbadger deleted the fix/improve-ignore-output branch August 25, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsapet elsapet elsapet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gotbadger @elsapet