Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ignore remove command #1221

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Aug 28, 2023

Description

Add bearer ignore remove <fingerprint> command
Use display method for scan warning about stale ignored fingerprints and include reference to ignore remove command

Visual changes

bearer ignore remove 111

Screenshot 2023-08-28 at 13 57 06

Scan message:
Screenshot 2023-08-28 at 14 45 02

Scan message when exclude-fingerprints is still used:

Screenshot 2023-08-28 at 14 52 28

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet elsapet requested a review from gotbadger August 28, 2023 12:02
@elsapet elsapet force-pushed the feat/add-ignore-remove-command branch from 1ea7277 to 784e873 Compare August 28, 2023 12:47
@elsapet elsapet merged commit 063492b into main Aug 28, 2023
9 checks passed
@elsapet elsapet deleted the feat/add-ignore-remove-command branch August 28, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants