fix: bearer-ignore-flag not loaded for scan

[elsapet]

Description

We weren't including ignore flags during scan, so bearer.ignore was not being loaded.
Also ensure we look to the right place if scan target is a path

Checklist

• I've added test coverage that shows my fix or feature works as expected.
• I've updated or added documentation if required.
• I've included usage information in the description if CLI behavior was updated or added.
• PR title follows Conventional Commits format

[elsapet]

For completeness, we'd probably want to add this flag to bearer actions too (as we have done for --config-file). What do you think @gotbadger

[gotbadger]

maybe move bearer-ignore-file to general flags since its used by more than just ignore commands?

[elsapet]

Curious here: is the following equivalent?

Suggested change

	configFilePath := viper.GetString(flag.ConfigFileFlag.ConfigName)
	configFilePath := viper.GetString(options.GeneralOptions.ConfigFile)

We use flag.ConfigFileFlag.ConfigName in the commands/scan.go but perhaps this is for performance or other reasons. Any light to be shed @didroe or @cfabianski? 🙏

[didroe]

In this case it's equivalent (without the viper.GetString). But in the scan command, we support reading the options from the config file. So we have to read it's location before building the options.

[elsapet]

Ahh, thanks for the explanation. So, if we wanted to support reading options from the config file in this case too, we should leave it as the following?

configFilePath := viper.GetString(flag.ConfigFileFlag.ConfigName)

[didroe]

Yeah. Basically we'd need to do this before calling <FLAGS>.ToOptions. And therefore you'd need to grab the filename manually first.