Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle comments for java #1474

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix: handle comments for java #1474

merged 1 commit into from
Jan 25, 2024

Conversation

cfabianski
Copy link
Collaborator

Description

Because the node Type was line_comment we weren't matching against it for expected rules (nor for disabled rules)
That fixes it.

Another approach would be to have the language report the comment node types but that felt overkill for now.

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@elsapet
Copy link
Contributor

elsapet commented Jan 25, 2024

Thanks @cfabianski 🙏

@cfabianski cfabianski merged commit e4c814e into main Jan 25, 2024
9 checks passed
@cfabianski cfabianski deleted the fix/magic-comment-expected branch January 25, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants