fix: return scan error if exists in parseDiff func #1508
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running Bearer with the
--diff
option and the scanner encounters an error it will return aError: signal: broken pipe
. This is because the error is not checked before returning from theparseDiff
function.Example command:
go run ./cmd/bearer/main.go scan ~/code/repo-with-long-line-diff --diff
An example error would be a diff that contains a line longer than the MaxScanTokenSize. (64 * 1024 bytes). With this additional code, the returned error will be
Error: bufio.Scanner: token too long
.I'll create a Github issue to accommodate a more thorough fix for handling long lines of diff.
Checklist