Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a tip about "Supermatter SLIVER" for random individual vocabulary #11113

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

EvilDragonfiend
Copy link
Member

@EvilDragonfiend EvilDragonfiend commented Jun 25, 2024

About The Pull Request

Adds a tip about "Supermatter SLIVER" for random individual vocabulary

  • There is no supermatter SILVER. There is only supermatter SLIVER.

Why It's Good For The Game

This word is easy to mistake.

Testing Photographs and Procedure

No need

Changelog

🆑
add: Added a tip to sillytips.txt: There is no supermatter SILVER. There is only supermatter SLIVER.
/:cl:

@EvilDragonfiend EvilDragonfiend changed the title Adds a tip about "Supermatter SLIVER" from random individual vocabulary Adds a tip about "Supermatter SLIVER" for random individual vocabulary Jun 25, 2024
@PowerfulBacon
Copy link
Member

is it actually spelt sliver? That's definitely a mistake lmao

@githubuser4141
Copy link
Contributor

githubuser4141 commented Jun 26, 2024

is it actually spelt sliver? That's definitely a mistake lmao

It shouldn't be a mistake, it matches up with the word's irl definition
Unless you're meant to be cutting a giant chunk of the SM away
image

@DrDuckedGoose
Copy link
Contributor

It's definitely meant to be 'sliver', 'silver' wouldn't make sense.

Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a meme tip

@EvilDragonfiend
Copy link
Member Author

This should be a meme tip

Well, I am not witty enough to write something funny for that. Any suggestion?

@PowerfulBacon
Copy link
Member

just move it to the meme tips file

@EvilDragonfiend
Copy link
Member Author

EvilDragonfiend commented Jul 1, 2024

just move it to the meme tips file

I figured. it's sillytips.txt. It has only 5% chance to appear, and it has 48 lines, which means 0.1% chance to see this message.
When there are not a few people who know the word incorrectly, including Bacon, I still think it's worth it to be a standard tip. Actual helpful tips are 284 lines(including this tip), and 95% chance to appear. It's 0.3% chance to appear.

but also, silly tips don't do anything. Correcting people's vocabulary is a positive thing, right?

I will move it to the silly tips if you still think it belongs to there.

Copy link
Contributor

@Rukofamicom Rukofamicom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is gonna make some people feel bad when they first see it.

@PowerfulBacon
Copy link
Member

Silly tips are for meme tips which this is. This doesn't actually give any advice

@tontyGH
Copy link
Contributor

tontyGH commented Jul 13, 2024

This seems like solid advice to me

@PowerfulBacon
Copy link
Member

I still stand by my last review, meme tips go in the meme tips file.

@EvilDragonfiend
Copy link
Member Author

addressed

@PestoVerde322 PestoVerde322 added this pull request to the merge queue Aug 6, 2024
Merged via the queue into BeeStation:master with commit 92b48b5 Aug 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants