-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datumizes storage from a component #11894
Draft
Tsar-Salat
wants to merge
51
commits into
BeeStation:master
Choose a base branch
from
Tsar-Salat:atom-storage
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+2,385
−2,561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solid-octo-guacamole
bot
added
Balance/Rebalance
Code Improvement
Feature
Refactor
Tweak
labels
Nov 17, 2024
ye, get this shit out quickly |
I swore I had a testing evidence. This was like 2 weeks ago I was just waiting for pref speedup pr lol Time to dig :( |
dreamseeker_wZ3bHmvYs8.mp4yea. Time to learn how actions work |
it seems action holder PR might be good to go with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR moves storage from being a component to being a datum.
We kill
/datum/component
and its handlerGetComponent()
, and replace it withatom_storage
andproc/create_storage(. . .)
Entirely removes signal overhead.
Included are some minor additional QOL/fixes for storage. (and some very not-minor fixes from the original tg pr)
Ports:
silent_for_user
var to mute storage messages only for the user. tgstation/tgstation#70941Why It's Good For The Game
We are making literal hundreds (maybe thousand) of GetComponent calls during initialize whenever we want to handle or modify the storage component. This is for every item.
This and the signal use contribute some not-so-insignificant overhead.
This makes that not happen. Yay.
The cool thing about atom storage is that, like the atomized integrity pr, you can now put it on nearly anything.
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑 rkz, magatsuchi, JohnFulpWillard, GuillaumePrata, Vishenka0704
refactor: refactored storage component to be datumized
tweak: tweaked overall weight of items so all the outfits fit again. TELL ME IF IT IS A SIGNIFICANT DEPARTURE FROM BEFORE, it should be about the same. Most of them were relating to ERT.
balance: increased the slots of ERT/Abductor bags because trying to fit all those items that featurecoders like to put in them was causing errors during outfit init.
tweak: decreased storage notification spam for ore bags
add: adds storage mass transferring to griddles
/:cl: