Skip to content
This repository was archived by the owner on Apr 20, 2021. It is now read-only.

Fix array parameters #280

Closed
wants to merge 2 commits into from
Closed

Fix array parameters #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e99d8e
Fix parameters with array
YoannChabert Jan 16, 2020
5d94af3
Merge branch 'master' into test-array-parameters
YoannChabert Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/Context/RestContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ public function iSendARequestToWithParameters($method, $url, TableNode $data)
{
$files = [];
$parameters = [];
$parametersInArray = [];

foreach ($data->getHash() as $row) {
if (!isset($row['key']) || !isset($row['value'])) {
Expand All @@ -53,15 +54,22 @@ public function iSendARequestToWithParameters($method, $url, TableNode $data)
if (is_string($row['value']) && substr($row['value'], 0, 1) == '@') {
$files[$row['key']] = rtrim($this->getMinkParameter('files_path'), DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR.substr($row['value'],1);
}
elseif (substr($row['key'], -1, 1) == ']') {
$parametersInArray[] = sprintf('%s=%s', $row['key'], $row['value']);
}
else {
$parameters[$row['key']] = $row['value'];
}
}

return $this->request->send(
if ($parametersInArray) {
parse_str(implode('&', $parametersInArray), $parametersInArray);
}

return $this->request->send(
$method,
$this->locatePath($url),
$parameters,
array_merge($parameters, $parametersInArray),
$files
);
}
Expand Down
7 changes: 7 additions & 0 deletions tests/features/rest.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,13 @@ Feature: Testing RESTContext
| item.id | 1 |
Then I should see "item.id=1"

Scenario: request parameter with array
https://github.com/Behatch/contexts/issues/261
When I send a POST request to "/rest/index.php" with parameters:
| key | value |
| item[id]| 1 |
Then I should see "item%5Bid%5D=1"

Scenario: Add header
Given I add "xxx" header equal to "yyy"
When I send a GET request to "/rest/index.php"
Expand Down