Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoR and TFT update #648

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

LoR and TFT update #648

wants to merge 4 commits into from

Conversation

skwiatko
Copy link

@skwiatko skwiatko commented Feb 1, 2020 •
edited
Loading

Hello!
I made some improvments to RiotSharp, everything need to be checked. Below list of changes.

Updated:
Misc:

  • GameMode (updated with new gameModes)
  • Language (some deleted but during tests I noticed they should stay, TBChecked)
  • MapType (updated map Ids with new maps)
  • Platform

Added:

  • LoR Endpoints
  • LoR Endpoints Tests
  • TFT League Endpoints
  • TFT League Endpoints Tests
  • TFT Match Endpoints
  • TFT Match Endpoints Tests
  • TFT Summoner Endpoints
  • TFT Summoner Endpoints Tests

Not deleted (but also not used):

  • ChampionEndpoint/ChampionList
  • ChampionEndpoint/ChampionRotation

I also moved tests to different files, it looks cleaner for me but i can revert these changes.

BenFradet
BenFradet reviewed Feb 19, 2020
View reviewed changes
Copy link
Owner

@BenFradet BenFradet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tft changes are addressed in #645 , so I'd advise you to remove these changes and leave the rest of them in 👍

and sorry for the long time to review

@skwiatko
Copy link
Author

Okay, i will wait for merge of tft pull to not mess too much 👍

@BenFradet
Copy link
Owner

yup good idea 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenFradet BenFradet BenFradet left review comments

@JanOuborny JanOuborny Awaiting requested review from JanOuborny

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skwiatko @BenFradet