-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timers and Delegates #1
base: main
Are you sure you want to change the base?
Conversation
norab7
commented
Jan 23, 2024
- Timers & Delays
- Blueprint Dispatchers
- Basic Actions
- Improved End Logic flow
- ActionUID
- Timers & Delays - Blueprint Dispatchers - Basic Actions - Improved Logic flow - ActionUID - JustAction actor
} | ||
} | ||
|
||
void USimpleAction::StartAction_Bound(AActor* NewActionActor, AActor* NewInstigator, FOnActionStartedDelegate Started, FOnActionInterruptedDelegate Interrupted, FOnActionEndedDelegate Ended, FOnActionCompleteDelegate Complete, FOnActionFailedDelegate Failed) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm iffy about this pattern being in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can figure out another method I'm all ears.
Can you show the difference between how the properties for an action show up if their categories are collapsed or not? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll wait for the change to finishing dispatcher to use enum/tags instead of splitting it.
I also see some egyptian brackets in there.
@@ -43,6 +43,17 @@ UWorld* USimpleAction::GetWorld() const | |||
return nullptr; | |||
} | |||
|
|||
FString USimpleAction::GetActionUID() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Store as FGuid
TArray<TObjectPtr<USimpleAction>> Actions; | ||
|
||
FSimpleActionList() : FSimpleActionList(TArray<USimpleAction*>()) {} | ||
FSimpleActionList(TArray<USimpleAction*> Actions) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the constructor is only called for making a new object. the new
was to avoid name conflicting, might not be necessary.