Pass merged manifest to Android Lint #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
approved these changes
Dec 15, 2023
|
@arunkumar9t2 thanks for the PR! Are you able to take a look at the failing tests? |
arunkumar9t2
force-pushed
the
arun/pass-merged-manifest
branch
from
c5e0f61 to
382228f
Compare
arunkumar9t2
force-pushed
the
arun/pass-merged-manifest
branch
from
ef991c7 to
7cb874a
Compare
arunkumar9t2
commented
Apr 15, 2024
| @@ -169,9 +174,10 @@ def process_android_lint_issues(ctx, regenerate): | |||
| # Append the Android manifest file. Lint requires that the input manifest files be named | |||
| # exactly `AndroidManifest.xml`. | |||
| manifest = ctx.file.manifest | |||
| if manifest and manifest.basename != "AndroidManifest.xml": | |||
There was a problem hiding this comment.
Lint does seem to work when we pass the file as-is - here it is passed as LibManifest.xml and baseline does report issues. Please let me know if there is any case I missed.
|
@Bencodes, please take a look, fixed tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass android merged manifest to Android Lint.
Implementation inspired from:
https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-main:lint/libs/lint-tests/src/test/java/com/android/tools/lint/ProjectInitializerTest.kt;l=1907