Vanilla Item Extension #302

DANRULEZ123 · 2024-11-26T19:33:31Z

35 New Items

Armor Trim Templates
Stuff from trial chamber update
Echo & Amethyst Shards
more

Added Echo Shards and Amethyst Crystals to item id map.

Add Echo Shard & Amethyst Crystal Item IDs.

Added Echo Shards & Amethyst Crystals to registered ids.

Removed getName()

Remove getName()

Changed amethyst_crystal to amethyst_shard to correct error.

Change ID

AMETHYST_CRYSTAL -> AMETHYST_SHARD

# Details: - 18 Armor Trim Templates (items) - 15 Other Vanilla Items

Registered new vanilla items.

Forgot SnifferEgg lol...

Fix invalid ID.

Fixed missing comma

Reverted to original

AzliRynz · 2024-11-30T15:20:34Z

I think there is a lack of implementation.

DANRULEZ123 · 2024-11-30T15:36:41Z

I think there is a lack of implementation.

Alright, what do you suggest adding then?

1.21.50 - Added Resin Clump & Resin Brick items.

No extra functionality needed.

Changed comment, the brushing animation already occurs.

Fixed typo that remained unnoticed for 4 years.

Attempt at making raw ores smeltable.

DANRULEZ123 · 2025-01-13T15:44:07Z

This should be stable enough to merge now.

TO-DO:

Implement full mace functionality
Implement Wind Charge entities
Modify Wind Charge Item to spawn the wind charge upon activating.

Changes

As requested, removed tons of unnecessary Item objects. Only keeping the ones that require additional functionality.
Added Bundles, along with their color variants.
Attempted to make raw ores smeltable by adding them to recipes.json.
Added more blocks to item_id_map.json (still needs implemented into block_id_map.json
Iron and Gold Ores now drop their respective raw materials.

Implemented 123 new block ids! (Use extended blocks to register and use)

DANRULEZ123 · 2025-01-15T15:59:37Z

Vanilla Block ID Extension:

Added 123 new blocks to block_id_map, once implemented, they should be usable via ExtendedBlocks.

TO-DO:

Implement full mace functionality
Implement Wind Charge entities
Modify Wind Charge Item to spawn the wind charge upon activating.
Register The Bundle along with its respective color variants.

Added previously implemented IDs that weren't here from item_id_map.json.

Remove unnecessary comment

Registered previously added items. (936-954)

DANRULEZ123 · 2025-01-18T15:20:28Z

New Items Registered

Registered block ids from 937-954.

Resin Bricks
Resin Clumps
Bundles (and their respective colors.) (938-954)

Benedikt05 · 2025-01-18T16:09:03Z

src/pocketmine/item/ItemFactory.php

+
+		// Register newer items.
+		self::registerItem(new Item(Item::ECHO_SHARD, 0, "Echo Shard"));
+		//self::registerItem(new Item(Item::AMETHYST_CRYSTAL, 0, "Amethyst Crystal"));


there is no AMETHYST_CRYSTAL constant

therefore, i commented it out (see my last commit)

I have fixed the issue. It was supposed to be AMETHYST_SHARD.

Benedikt05 · 2025-01-18T16:11:56Z

src/pocketmine/item/RawCopper.php

+use pocketmine\block\Block;
+use pocketmine\Player;
+
+class RawCopper extends Item {


there is no point of this class

Benedikt05 · 2025-01-18T16:12:45Z

src/pocketmine/item/RawGold.php

+use pocketmine\block\Block;
+use pocketmine\Player;
+
+class RawGold extends Item {


same as for RawCopper

Benedikt05 · 2025-01-18T16:13:04Z

src/pocketmine/item/RawIron.php

+use pocketmine\block\Block;
+use pocketmine\Player;
+
+class RawIron extends Item {


same as for RawCopper

I forgot to remove them because I was trying to make them smeltable which wasn't possible through those classes.

Fixed typo for Amethyst Crystals/Shards. The wrong constant was used. (AMETHYST_CRYSTAL -> AMETHYST_SHARD)

DANRULEZ123 · 2025-01-18T16:44:28Z

Fixes

Fixed invalid constant for Amethyst Crystal/Shard
Removed Raw Iron, Gold, and Copper classes.

AzliRynz · 2025-02-28T12:46:13Z

@Benedikt05 It might be better if this PR is closed.

Benedikt05 · 2025-02-28T14:41:11Z

it was planned to be merged, i just havent found the time to do some minor adjustments

DANRULEZ123 added 22 commits November 21, 2024 08:52

Update Player.php

930c1b4

Update item_id_map.json

924dcf6

Added Echo Shards and Amethyst Crystals to item id map.

Create EchoShard.php

62f2ebf

Create AmethystCrystal.php

0a7a013

Update ItemIds.php

8a8462c

Add Echo Shard & Amethyst Crystal Item IDs.

Update ItemFactory.php

5af1f6a

Added Echo Shards & Amethyst Crystals to registered ids.

Merge branch 'Benedikt05:master' into master

9d8aca4

Update AmethystCrystal.php

2efd8e1

Removed getName()

Update EchoShard.php

96531c8

Remove getName()

Update item_id_map.json

6dea268

Changed amethyst_crystal to amethyst_shard to correct error.

Update AmethystCrystal.php

67a3827

Change ID

Update ItemIds.php

646e77d

AMETHYST_CRYSTAL -> AMETHYST_SHARD

Create Directory

ed9c384

Delete src/pocketmine/item/trims/Directory

90747bf

Added 33 Vanilla Items!

d9a50e7

# Details: - 18 Armor Trim Templates (items) - 15 Other Vanilla Items

Update ItemIds.php - +33 Item Ids

dd968c7

Update item_id_map.json +33 Vanilla Items

fdb3e48

Update ItemFactory.php

5e5b418

Registered new vanilla items.

Create SnifferEgg.php

c0424da

Forgot SnifferEgg lol...

Update Dune.php

d3d99cf

Fix invalid ID.

Update item_id_map.json

9d8c34b

Fixed missing comma

Update Player.php

42f2333

Reverted to original

DANRULEZ123 added 6 commits December 4, 2024 05:49

Update item_id_map.json

ba20de4

1.21.50 - Added Resin Clump & Resin Brick items.

Delete src/pocketmine/item/AmethystCrystal.php

344ef5c

No extra functionality needed.

Delete src/pocketmine/item/ArmadilloScute.php

d7494f4

No extra functionality needed.

Delete src/pocketmine/item/BreezeRod.php

0e2d09d

No extra functionality needed.

Delete src/pocketmine/item/Bolt.php

18524ed

No extra functionality needed.

Update Brush.php

721cd05

Changed comment, the brushing animation already occurs.

DANRULEZ123 added 3 commits January 13, 2025 10:09

Update MobSpawner.php

584c029

Fixed typo that remained unnoticed for 4 years.

Update recipes.json

60f8fb2

Attempt at making raw ores smeltable.

Add WIND_CHARGE_PROJECTILE Entity ID.

437bda8

Update block_id_map.json

f71fb4c

Implemented 123 new block ids! (Use extended blocks to register and use)

DANRULEZ123 added 3 commits January 18, 2025 10:01

Update ItemIds.php

165bca5

Added previously implemented IDs that weren't here from item_id_map.json.

Update ItemIds.php

99b02d7

Remove unnecessary comment

Update ItemFactory.php

a430dab

Registered previously added items. (936-954)

fix: addressed multiple syntax errors

16f359a

Benedikt05 reviewed Jan 18, 2025

View reviewed changes

DANRULEZ123 added 4 commits January 18, 2025 11:36

Update ItemFactory.php

79ed84e

Fixed typo for Amethyst Crystals/Shards. The wrong constant was used. (AMETHYST_CRYSTAL -> AMETHYST_SHARD)

Delete src/pocketmine/item/RawCopper.php

aff6175

Delete src/pocketmine/item/RawGold.php

93d87bd

Delete src/pocketmine/item/RawIron.php

13bb195

DANRULEZ123 added 6 commits January 27, 2025 12:25

Implement modern items to creative inv

15c0be0

Update README.md

bde3665

Update README.md

62e5cf9

Attempt to correctly register education edition content.

ba5a19a

Update README.md

6d3729a

Update README.md

8360e7b

Benedikt05 self-requested a review February 12, 2025 22:44

DANRULEZ123 closed this Feb 28, 2025

Vanilla Item Extension #302

Vanilla Item Extension #302

Uh oh!

Conversation

DANRULEZ123 commented Nov 26, 2024

Uh oh!

AzliRynz commented Nov 30, 2024

Uh oh!

DANRULEZ123 commented Nov 30, 2024

Uh oh!

DANRULEZ123 commented Jan 13, 2025

TO-DO:

Changes

Uh oh!

DANRULEZ123 commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Vanilla Block ID Extension:

TO-DO:

Uh oh!

DANRULEZ123 commented Jan 18, 2025

New Items Registered

Uh oh!

Benedikt05 Jan 18, 2025

Choose a reason for hiding this comment

Uh oh!

Benedikt05 Jan 18, 2025

Choose a reason for hiding this comment

Uh oh!

DANRULEZ123 Jan 18, 2025

Choose a reason for hiding this comment

Uh oh!

Benedikt05 Jan 18, 2025

Choose a reason for hiding this comment

Uh oh!

Benedikt05 Jan 18, 2025

Choose a reason for hiding this comment

Uh oh!

Benedikt05 Jan 18, 2025

Choose a reason for hiding this comment

Uh oh!

DANRULEZ123 Jan 18, 2025

Choose a reason for hiding this comment

Uh oh!

DANRULEZ123 commented Jan 18, 2025

Fixes

Uh oh!

AzliRynz commented Feb 28, 2025

Uh oh!

Benedikt05 commented Feb 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DANRULEZ123 commented Jan 15, 2025 •

edited

Loading