Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more hard coding Native Libraries #13

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

No more hard coding Native Libraries #13

wants to merge 6 commits into from

Conversation

jbonnett92
Copy link

The new class changes the native library depending on what OS the program is ran from.

Added Library loader, to load a particular library depending on what OS the program is running on
Library loader class, to load a particular library depending on the OS running the program.
This means you do not have to set the native library location for the lwjgl.jar.
@fhntv24
Copy link
Contributor

fhntv24 commented Jun 11, 2014

If you want it to be accepted - better to move LibaryLoader to engine.core
oh and btw it will not work , beacos OpenAL isnt used here at all.
And folders are lib/natives/someting .Oh , and how about "solaris"? He needs diffrent libs from linux i think.

@jbonnett92
Copy link
Author

It work's with mine... Tried on all 3.

@fhntv24
Copy link
Contributor

fhntv24 commented Jun 12, 2014

Solaris folder there is for reason.You know that,right?

Oh and really - its better to be in engine.core , its more logical to be there..
And maybe you will make libs.jar loader as well?

Moved from com.base.game...
Allows you to automatically load native libraries rather than hard coding them into "lwjgl.jar" via native library location.
@jbonnett92
Copy link
Author

Well I did the changes apart from creating the libs.jar.

@fhntv24
Copy link
Contributor

fhntv24 commented Jun 12, 2014

Oh you cold just edit path when editing file , its easy.Just hit backspace on begining of filename.Its better that creating/deleting files ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants