Version 1.3.0 #11
Merged
Version 1.3.0 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(no behaviour change, still defaults with op)
add allowed commands whitelist, and move full bypass check to permission
refactor + add /parkour quit command
fix whitespace, by creating another large whitespace diff :/ sorry
puts relavant players in creative on every island enter
Two tests are still WIP.
Added **warped pressure plate**
…eative add more cases where the gamemode should be updated
Some of the listeners were firing in other game modes so I added code to check for the world and also to prevent accidental use in the future. i.e., throw and exception. Parkour keeps its own table of islands in the database and we don't want non-parkour islands to end up in there. Reworked the CourseRunnerLister test to include the new teleport listener.
As the main point of the class seems to be to record the timers and checkpoints, then the record type can provide that easily without the getters.
Uses a record for the Parkour run data
This won't stop people setting them and removing the plates later though...
456dev
requested changes
Aug 3, 2023
456dev
approved these changes
Aug 3, 2023
456dev
requested changes
Aug 3, 2023
src/main/java/world/bentobox/parkour/listeners/CourseRunnerListener.java
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
456dev
approved these changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we're ready for another release!