Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix repeated checkpoint setting + bypass teleport check for back-to-checkpoint teleports + fix replacing checkpoints with the pressure plate #14

Merged
merged 5 commits into from
Aug 10, 2023

Conversation

456dev
Copy link
Collaborator

@456dev 456dev commented Aug 9, 2023

various fixes

add list of players that are currently teleporting, and should be ignored from canceling their run parkourRunRecord
change the checkpoint manager to store block locations, teleporting players to the middle of the block on recall.
(better comparison to avoid re-setting the location on the same block)

use currentlyTeleporting to ensure only players teleported by the plugin (for respawning at checkpoint) will be allowed to continue their run
refactor uuid
use more descriptive names for locations
change checkpoint store to use block locations, so comparisons can more accurately be made
…ace exisitng warps on placement of further pressure plates

instead, the conversion from block location (on pressure plate place)  to player location (on teleport) is done just for that one path
@456dev 456dev requested a review from tastybento August 9, 2023 21:51
Copy link
Member

@tastybento tastybento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me, but have a look at the async teleport. Not a biggie but we may as well do it.

@456dev 456dev requested a review from tastybento August 10, 2023 20:12
@tastybento tastybento merged commit 1724823 into BentoBoxWorld:develop Aug 10, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants