Refactored FORTRAN module #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clearer formatting and indentation. Refactored repetitive code using `associate`. Added inline comments for clarity. Enhanced readability and consistency.
|
Hi @Montana, thanks for reaching out and we generally do appreciate genuine community contributions. Unfortunately this PR seems to propose purely cosmetic/syntactic changes, with no real semantic content. It looks like the work was probably done with an automated tool, and (aside from a few very minor new comments) provides no obvious maintainability benefit. It also modifies only one test in a larger suite of tests, and additionally has conflicts with some other changes already merged (PR #174) and in-flight (PRs #169 and #158) for the target branch. Declined without prejudice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
associate.