Repository navigation
T-22776 [CI] One-off probe: Firehose delivery errors without logs:CreateLogGroup (not for merging) - #20
Closed
PetrHeinz wants to merge 1 commit into
Conversation
…merging) Replaces the E2E on this branch with one run that deploys the stack with a source token ingest does not know and retries off, then checks that Firehose writes its delivery errors into both /aws/kinesisfirehose/better-stack-* log groups while better-stack-firehose-role has no logs:CreateLogGroup. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not for merging. One run that answers the question on #18: does Firehose still write its delivery errors into
/aws/kinesisfirehose/better-stack-logsand/aws/kinesisfirehose/better-stack-metricswhenbetter-stack-firehose-rolehas nologs:CreateLogGroup?Result: yes. Run https://github.com/BetterStackHQ/aws/actions/runs/43446705641 passed:
better-stack-firehose-rolehad no managed policy and onlylogs:CreateLogStreamandlogs:PutLogEvents.DestinationDeliverylog streams received Firehose's error events, the first one inbetter-stack-logs67 s after the first record went in:logs/errors/http-endpoint-failed/andmetrics/errors/http-endpoint-failed/.CreateLogGroupcalls during the run, all successful and all from the session that deployed the stack. Firehose made none, allowed or denied.How the run forces the error: this branch sits on top of #18 and replaces
.github/workflows/e2e.ymlwith a probe.FirehoseRetryDurationSeconds=0, so every Firehose batch is rejected with HTTP 401.better-stack-metricsby itself.better-stack-logsgets hand-made CloudWatch Logs subscription records throughput-record.The usual cleanup deleted the stack and the source.
🤖 Generated with Claude Code