feat: Implement account deactivation using Kakao unlink #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rlooo
commented
Feb 16, 2025
•
rlooo
commented
디비에서 바로 삭제하는 것이 아닌 soft 삭제를 이용하여 isDeleted로 탈퇴회원을 구분하도록 구현하였습니다.
추후 탈퇴 정책을 정의하여 배치를 돌려 주기적으로 삭제하도록 작업할 예정입니다.
auto-assign
bot
requested review from
chsjen492,
HeesooJun,
joonamin,
laggu,
sezeme and
yuchem2
|
탈퇴한 회원이 재가입할 경우는 어떻게 되나요? 이 부분은 따로 없는 것 같아서요! |
laggu
reviewed
Feb 16, 2025
laggu
reviewed
Feb 16, 2025
탈퇴한 회원이 재가입할 때, 기존의 isDeleted 플래그를 false로 변경하도록 처리하는 부분 추가하였습니다 |
laggu
previously approved these changes
Feb 17, 2025
|
탈퇴할때 해당 유저가 작성한 schedule 과 event 를 어떻게 할건지 정책이 필요합니다 |
|
conflict 났어요 |
laggu
reviewed
Feb 20, 2025
| @@ -8,6 +8,14 @@ export class UnknownUserError extends APIError { | |||
| } | |||
| } | |||
|
|
|||
| export class DeletedUserError extends APIError { | |||
| constructor(cause: Error | string = null) { | |||
| super(404, 4100, 'deleted user error', cause) | |||
There was a problem hiding this comment.
Suggested change
| super(404, 4100, 'deleted user error', cause) | |
| super(404, 4101, 'deleted user error', cause) |
추후 탈퇴 정책 정의 및 작업할 때 함께 진행하겠습니다. |
…ctivated accounts
rlooo
force-pushed
the
FIENMEE-100
branch
2 times, most recently
from
d7233b7 to
ae1b73f
Compare
laggu
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.