feat: add validate schedule middleware
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
laggu
reviewed
Dec 2, 2024
apps/server/package.json
Outdated
| @@ -13,6 +13,7 @@ | |||
| "private": true, | |||
| "dependencies": { | |||
| "@typegoose/typegoose": "^12.9.0", | |||
| "@types/node": "^20", | |||
There was a problem hiding this comment.
이건 제가 실수로 다른 작업하다가 섞인 것 같아요 제거하고 다시 커밋 올리겠습니다!
laggu
reviewed
Dec 2, 2024
| @@ -41,8 +42,7 @@ router.get('/', async (req: Request, res: Response) => { | |||
| res.status(200).json(schedules) | |||
| }) | |||
|
|
|||
| router.delete('/:id', async (req: Request, res: Response) => { | |||
| // TODO: 작성자가 jwt에 있는 userId와 일치하는지 검증하는 middleware 추가 | |||
| router.delete('/:id', middlewares.schedules.verifyAuthorMiddleware, async (req: Request, res: Response) => { | |||
| await ScheduleModel.deleteOne({ _id: req.params.id }) | |||
| res.sendStatus(204) | |||
| }) | |||
laggu
reviewed
Dec 2, 2024
| @@ -0,0 +1,9 @@ | |||
| import { APIError } from '@/types/errors/error' | |||
|
|
|||
| export class UnAuthorizedSchedule extends APIError { | |||
There was a problem hiding this comment.
Suggested change
| export class UnAuthorizedSchedule extends APIError { | |
| export class UnauthorizedSchedule extends APIError { |
laggu
reviewed
Dec 2, 2024
|
|
||
| export class UnAuthorizedSchedule extends APIError { | ||
| constructor(cause: Error | string = null) { | ||
| super(401, 40100, 'unauthorized schedule', cause) |
There was a problem hiding this comment.
별거 아니라 넘어가도 되는데 만 단위는 너무 큰거 같아요
에러 십만개 만들거 같지 않아서요...
Suggested change
| super(401, 40100, 'unauthorized schedule', cause) | |
| super(401, 4010, 'unauthorized schedule', cause) |
There was a problem hiding this comment.
xxx00 이런식으로 xxx status code에 대한 세부 원인을 00 ~ 99 까지 2자리 수로 표현하고 싶었어요.
한 자리 수는 너무 적다는 생각을 했었거든요..! 한 자리 수도 적당하다고 생각하시는거라면 리뷰에 반영하겠습니다!
laggu
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.