-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color histogram with floats #18
base: main
Are you sure you want to change the base?
Conversation
…es column with floats
…ion_method and calculates a median histogram to be used as overlay Also add: - histogram_interpolation - overlay_interpolation - overlay_opacity - overlay_visible - calculate_statistic histogram - array_to_pcolormesh_rgba
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 90.66% 92.19% +1.53%
==========================================
Files 7 8 +1
Lines 621 897 +276
==========================================
+ Hits 563 827 +264
- Misses 58 70 +12 ☔ View full report in Codecov by Sentry. |
ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
…default categorical overlay_colormap, set min norm value to non-zero when norm is log
…tion for scatter and histogram for both categorical and continuous colormaps categorical colormaps only accept linear normalization(log, symlog and centered are ignored in this case) if data is float with categorical colormap, linear normalization is used if colormap is continuous, all normalization methods are accepted, but limits may be adjusted
- remove 'normalization_method' parameter from array_to_pcolormesh_rgba - rename indices_in_above_threshold_patches method to indices_in_patches_above_threshold - don't draw the overlay if all values are NaN - initialize self._overlay_visible
…_color_normalization_method property
… where no computations were done
Hi @jo-mueller , I am adding here the possibility to display the scatter colors or an histogram overlay based o another features column (not just a categorical array with integers, but rather any float array with a continuous colormap - I renamed You can get a feeling of the changes by running the Artists notebook again, which I updated. Of course a histogram overlay completely hides the original histogram, but it may be useful if the user hide and show it quickly or change its opacity for example. When you get some time, could you please give it a try to check if we can merge this? |
Hi @zoccoler , sorry for the late reply. I am a bit undecided on this implementation: On the one hand I like the simplicity of this: Simply change the colormap to something continuous, pass a float to the color indices and have your plot colored. On the other hand, it loads the same property (color) with potentially multiple meanings. In the context of the clusters plotter, it would be hard to use colored scatter points in conjunction with the clustering. As an alternative suggestion: Would you think that it could make sense to forward the coloring done with Let me know what you think! |
Hi @jo-mueller , I think we both agree that displaying a feature with different colors is a good enhancement (it also fits the goal of this PR). Using the edge colors for categories can indeed be a solution, we just have to test if it doesn't look confusing. This wouldn't work for the histogram though. I will try to generate some examples for these ideas here, then we can decide. |
This adds the possibility to assign an array with floats (like representing some feature) as an overlay to the histogram and to the scatter plot.