Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new viz functions #113

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adding new viz functions #113

wants to merge 5 commits into from

Conversation

darh78
Copy link
Contributor

@darh78 darh78 commented Sep 19, 2019

Adding new visualization functions to:

  • Visualize Run Differentials within a season
  • Visualize Standings timeline (Game Behind & Winning Percentage) within a date period in a season

@darh78
Copy link
Contributor Author

darh78 commented Jan 15, 2020

Hi @BillPetti,

I’m wondering if this function would be included in the next release.

Thanks for your thoughts.

Daniel

@BillPetti
Copy link
Owner

@darh78 Can you please submit pull requests to the development branch? This way I can test the functions more easily and ensure they work without affecting the master branch. Also, I only see .R files here. You should run devtools::document to generate the .man files as well as automatically generate any import or export updates to the NAMESPACE file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants