attempt at Chadwick installation checks; #307 #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiemgilani
approved these changes
Nov 29, 2023
|
I'm not really sure if this does work but we will try it on main and get it fixed if there are issues once we really check it closes #307 |
|
FYI, we are hoping to send the book to the publisher next week. This function is currently not included in the book. (See https://beanumber.github.io/abdwr3e/A_retrosheet.html#sec-chadwick for a function with similar functionality.) However, that could be changed (but only before next week). |
|
It's included on the main branch and will be included in the CRAN version assuming the function doesn't get flagged by CRAN for not meeting some requirements |
|
OK, sounds good! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grateful for feedback on this PR for #307 !