Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optimised findfirst etc #8

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Add optimised findfirst etc #8

merged 6 commits into from
Dec 11, 2024

Conversation

jakobnissen
Copy link
Member

@jakobnissen jakobnissen commented Dec 10, 2024

The default methods needlessly boundscheck, which can be a serious performance concern.

TODO:

  • Memrchr based method
  • Fix ambiguity w. base on nightly
  • Add an optimised method when iszero is the function

The default methods needlessly boundscheck, which can be a serious performance
concern.
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.34%. Comparing base (cbab8ab) to head (d430114).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/basic.jl 96.29% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   98.96%   98.34%   -0.63%     
==========================================
  Files           5        5              
  Lines         194      242      +48     
==========================================
+ Hits          192      238      +46     
- Misses          2        4       +2     
Flag Coverage Δ
unittests 98.34% <96.29%> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakobnissen jakobnissen merged commit 83b4218 into master Dec 11, 2024
11 checks passed
@jakobnissen jakobnissen deleted the find branch December 11, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant