-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multiple matrices and improving construction of TileDB objects #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…nto refactor-layers
for more information, see https://pre-commit.ci
…uerying; updating tests and documentation as well
…nto refactor-layers
for more information, see https://pre-commit.ci
keviny2
approved these changes
Nov 26, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
jkanche
changed the title
refactor the build functionality
Support for multiple matrices and improving construction of TileDB objects
Nov 28, 2024
…nto refactor-layers
for more information, see https://pre-commit.ci
This was referenced Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces major improvements to matrix handling, storage, and performance, including support for multiple matrices in H5AD/AnnData workflows and optimizations for ingestion and querying.
Support for multiple matrices:
build_cellarrdataset
andCellArrDataset
now support multiple matrices. During ingestion, a TileDB group called"assays"
is created to store all matrices, along with group-level metadata.This may introduce breaking changes with the default parameters based on how these classes are used. Previously to build the TileDB files:
Now you may provide a list of matrix options for each layers in the files.
Querying follows a similar structure:
assay_uri
is relative toassay_tiledb_group
. For backwards compatibility,assay_tiledb_group
can be an empty string.Parallelized ingestion:
The build process now uses
num_threads
to ingest matrices concurrently. Two new columns in the sample metadata,cellarr_sample_start_index
andcellarr_sample_end_index
, track sample offsets, improving matrix processing.spawn
method on UNIX systems, which may affect usage on windows machines.TileDB query condition fixes:
Fixed a few issues with fill values represented as bytes (seems to be common when ascii is used as the column type) and in general filtering operations on TileDB Dataframes.
Index remapping:
Improved remapping of indices from sliced TileDB arrays for both dense and sparse matrices. This is not a user facing function but an internal slicing operation.
Get a sample:
Added a method to access all cells for a particular sample. you can either provide an index or a sample id.