Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection code clean up #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

stevenzhang717
Copy link
Collaborator

  • clean up your connection code, you don't need to return a function, just return the object, if you import your module somewhere else, those object could be reuse
  • extracted database creation script
    -add creation script to connection.js, please test if it works with your migration process.

@stevenzhang717 stevenzhang717 requested a review from JasonShin June 7, 2017 13:17
@stevenzhang717
Copy link
Collaborator Author

you might want to check if the my db code could work with your db migration code, when i ran the first time, it had some transaction issue.

@JasonShin
Copy link
Member

It doesn't contain connection code clean up. And could you please remove sql file since it won't be used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants