Skip to content

feat(wrapperModules.gh): init #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rachitvrma wants to merge 4 commits into
base: main
Choose a base branch
from
+39 −0
Open

feat(wrapperModules.gh): init #336

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d571568
feat(wrapperModules.gh): Wrapper for github-cli
Mar 13, 2026
c5b3ebb
fix: take env block out of drv block
Mar 13, 2026
ab47107
fix: add import for wlib.modules.default
Mar 13, 2026
707b7fe
modify: remove passAsFile
Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions wrapperModules/g/gh/module.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
{
wlib,
lib,
pkgs,
config,
...
}:
let
yamlFormat = pkgs.formats.yaml { };
inherit (lib) mkOption;
in
{
imports = [ wlib.modules.default ];
options = {
settings = mkOption {
inherit (yamlFormat) type;
default = { };
description = ''
Configuration that goes to {file}`config.yml`
'';
};
};
config = {
package = lib.mkDefault pkgs.gh;
env = {
GH_CONFIG_DIR = "${placeholder config.outputName}/gh-config";
};
drv = {
configYml = yamlFormat.generate "config.yml" config.settings;
passAsFile = [
"configYml"
];
buildPhase = ''
runHook preBuild
mkdir -p "${placeholder config.outputName}/gh-config"
cp "$(cat "$configYmlPath")" "${placeholder config.outputName}/gh-config/config.yml"
Copy link
Copy Markdown
Owner

@BirdeeHub BirdeeHub Mar 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are already doing some complicated thing here to build the directory, we can make this do placeholders without much extra effort, if you want?

If you set config.drv.nativeBuildInputs = [ pkgs.remarshal_0_17 ];

You can then configContent = builtins.toJSON config.settings;

and json2yaml $configContentPath "${placeholder config.outputName}/gh-config/config.yml" instead of this copy command.

Which is how they do it in nixpkgs

https://github.com/NixOS/nixpkgs/blob/87e875c8ea73c14dd96a883e37c691ab01c9da9e/pkgs/pkgs-lib/formats.nix#L165-L172

Alternatively, if you don't want all that, we should be able to simplify this line to

cp "$configYml" "${placeholder config.outputName}/gh-config/config.yml"

and then remove the passAsFile, which is not necessary in this case. configYml in this case as it is currently written contains a path. A single path is very very unlikely to ever exceed the max length for a variable. So if we are going to continue using .generate, you don't need passAsFile there either.

runHook postBuild
'';
};
meta.maintainers = [ wlib.maintainers.rachitvrma ];
};
}
Loading